Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cookies and headers for request using in RSC #31623

Merged
merged 6 commits into from
Nov 22, 2021
Merged

Add cookies and headers for request using in RSC #31623

merged 6 commits into from
Nov 22, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Nov 19, 2021 •
edited
Loading

  • Passdown the request with richer information
  • test: access request header as prop from gSSP

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Nov 19, 2021
shuding
shuding reviewed Nov 19, 2021
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for it?

@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@huozhi huozhi requested a review from shuding November 22, 2021 15:39
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Nov 22, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js rsc/req Change
buildDuration 16.9s 17s ⚠️ +90ms
buildDurationCached 3.4s 3.4s ⚠️ +14ms
nodeModulesSize 339 MB 339 MB ⚠️ +115 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js rsc/req Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.726 2.752 ⚠️ +0.03
/ avg req/sec 917 908.39 ⚠️ -8.61
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.145 1.146 0
/error-in-render avg req/sec 2183.89 2181.07 ⚠️ -2.82
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js rsc/req Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 28.4 kB 28.4 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.2 kB 72.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js rsc/req Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js rsc/req Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 635 B 635 B ✓
image-HASH.js gzip 4.45 kB 4.45 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.87 kB 1.87 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 13.3 kB 13.3 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js rsc/req Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary huozhi/next.js rsc/req Change
index.html gzip 532 B 532 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js rsc/req Change
buildDuration 18.7s 18.7s ⚠️ +76ms
buildDurationCached 3.4s 3.4s -23ms
nodeModulesSize 339 MB 339 MB ⚠️ +115 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js rsc/req Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.743 2.687 -0.06
/ avg req/sec 911.44 930.23 +18.79
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.153 1.155 0
/error-in-render avg req/sec 2168.33 2163.94 ⚠️ -4.39
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js rsc/req Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.6 kB 28.6 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 72.5 kB 72.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js rsc/req Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary huozhi/next.js rsc/req Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 622 B 622 B ✓
image-HASH.js gzip 4.47 kB 4.47 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 1.91 kB 1.91 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 13.2 kB 13.2 kB ✓
Client Build Manifests
vercel/next.js canary huozhi/next.js rsc/req Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary huozhi/next.js rsc/req Change
index.html gzip 533 B 533 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: 94e3126

@kodiakhq kodiakhq bot merged commit 7f58a2e into vercel:canary Nov 22, 2021
@huozhi huozhi deleted the rsc/req branch November 22, 2021 18:53
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuding shuding shuding approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@padmaia padmaia Awaiting requested review from padmaia

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huozhi @ijjk @shuding